-
Notifications
You must be signed in to change notification settings - Fork 497
feat(jenkins): remove deprecated 'jenkins' package #5793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Changed Packages
|
|
So far no issues connecting to my Jenkins instance: basic-jenkins-test.mp4Jenkins scaffolder also works: jenkins-scaffolder-test.mp4 |
f2aa3e7 to
73778d2
Compare
Remove the deprecated 'jenkins' package and replace it with a built-in, light-weight client. Signed-off-by: Bryan Ramos <[email protected]>
73778d2 to
72bb011
Compare
Signed-off-by: Bryan Ramos <[email protected]>
Signed-off-by: Bryan Ramos <[email protected]>
Signed-off-by: Bryan Ramos <[email protected]>
Signed-off-by: Bryan Ramos <[email protected]>
Signed-off-by: Bryan Ramos <[email protected]>
Signed-off-by: Bryan Ramos <[email protected]>
Signed-off-by: Bryan Ramos <[email protected]>
Signed-off-by: Bryan Ramos <[email protected]>
|
This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution! |
|
Bump for stale bot |
|
Sorry this isn't getting the review it needs @CryptoRodeo. I'm heads down prepping for BackstageCon on Monday. But this is on my radar to review in full! |
|
No worries. Thanks for the heads up @awanlin , have fun at BackstageCon! |
Hey, I just made a Pull Request!
Remove the deprecated jenkins NPM package and replace it with a built-in lightweight client.
The goal of this client is for it to be "drop-in" and minimize changes where the original client was called.
Should fix #4984
Basic Jenkins plugin operations
These still work as expected (at least for me 😄)
jenkins-backstage-demo-basic.mp4
Scaffolder functionality
The Scaffolder still works the same:
jenkins-scaffolder-demo-basic.mp4
For reference here is the template I used:
✔️ Checklist
Signed-off-byline in the message. (more info)